Skip to content

only save when needed within is_taken #6558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2025
Merged

only save when needed within is_taken #6558

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions kitsune/questions/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -708,10 +708,10 @@ def is_taken(self):
this will reset the database fields and return False.
"""
if self.taken_by is None or self.taken_until is None or self.taken_until < datetime.now():

self.taken_by = None
self.taken_until = None
self.save()
if (self.taken_by is not None) or (self.taken_until is not None):
self.taken_by = None
self.taken_until = None
self.save()
return False
return True

Expand Down